Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Burn hangs when DisplayInternalUI="yes" package shows message #4094

Closed
wixbot opened this issue Aug 30, 2013 · 6 comments
Closed

Burn hangs when DisplayInternalUI="yes" package shows message #4094

wixbot opened this issue Aug 30, 2013 · 6 comments
Assignees
@aleksandr-grechko
Labels
bug burn
Milestone
v3.x

Comments

@wixbot
Copy link

wixbot commented Aug 30, 2013

Setup hang on the msi welcome dialog (launched from burn with DisplayInternalUI="yes") if show message box from custom action.

Custom action code:

int ShowWarningCode(int iCode) 
{

    PMSIHANDLE Rec = ::MsiCreateRecord(1);
    UINT er = ::MsiRecordSetInteger(Rec, 1, iCode);

    return (er = ::MsiProcessMessage(WcaGetInstallHandle(), static_cast<INSTALLMESSAGE>(MB_OK | INSTALLMESSAGE_WARNING), Rec));
}

UINT __stdcall CustomAction1(MSIHANDLE hInstall)
{
    HRESULT hr = S_OK;
    UINT er = ERROR_SUCCESS;

    hr = WcaInitialize(hInstall, "CustomAction1");
    ExitOnFailure(hr, "Failed to initialize");

    WcaLog(LOGMSG_STANDARD, "Initialized.");

    ShowWarningCode(25000);


LExit:
    er = SUCCEEDED(hr) ? ERROR_SUCCESS : ERROR_INSTALL_FAILURE;
    return WcaFinalize(er);
}

Msi code:

<InstallUISequence>
  <Custom Action='CustomAction1' After='CostFinalize'>NOT Installed</Custom>
</InstallUISequence>

Bundle code:

  <MsiPackage Id="SetupProjectCAMsg.msi" Visible="yes" DisplayInternalUI="yes" Compressed="no" Cache="no" SourceFile="SetupProjectCAMsg.msi"/>

Originally opened by sergju
@wixbot
Copy link
Author

wixbot commented Aug 30, 2013

Please post a Burn log from that run to GDrive/SkyDrive/DropBox/etc and add a comment here with the link.

Originally posted by barnson

@wixbot
Copy link
Author

wixbot commented Sep 2, 2013

Hang setup screenshot:
https://www.dropbox.com/s/uxb23hqwa02wud5/shot_130827_122232.png
If to kill bootstrapper exe screenshot:
https://www.dropbox.com/s/75weqfpoui99nib/WindowsAfterKillingBootstrapper.jpg
Log file:
https://www.dropbox.com/s/1xlk1i341b76nxv/Bootstrapper_20130902110137_0_SetupProjectCAMsg.msi.log

I am sure, that bootstrapper application hook message window, but doesn't show it.
The trouble with wix 3.8, with wix 3.7 all ok.

Originally posted by sergju

@wixbot
Copy link
Author

wixbot commented Sep 5, 2013

Originally posted by sergju

@wixbot
Copy link
Author

wixbot commented Sep 19, 2013

Originally changed by barnson
Release changed from v3.8 to v3.x

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@aleksandr-grechko
Copy link

Hi,
We need to check if current package shows internal UI before show MSI message like it is done in OnError handler in WixStandardBootstrapperApplication.
I would like to fix this defect.

@rseanhall
Copy link
Contributor

@aleksandr-grechko Thanks for volunteering! In order to assign you this bug, I have to add you as an external contributor. Look for a confirmation email from GitHub for this. Also, make sure to check out our development page for how to get started.

@aleksandr-grechko aleksandr-grechko mentioned this issue Feb 10, 2017
Merged
@rseanhall rseanhall mentioned this issue Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleksandr-grechko aleksandr-grechko

Labels
bug burn
Projects
None yet
Milestone
v3.x
Development

No branches or pull requests
3 participants
@aleksandr-grechko @rseanhall @wixbot