New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quantize constants and test #383
Conversation
Co-authored-by: Matthew Thompson <fortran@gmail.com>
Co-authored-by: Matthew Thompson <fortran@gmail.com>
@edwardhartnett I'm looking at the outstanding PR's to get them integrated into the 4.6.1 release we need to get out. I'll dig into this, the tests are important, but I thought I'd ping you to see if anything leaps out at you. |
Stand by I will take a look... |
@WardF I am working on this but have some other stuff going on. I will try to get this complete early next week. |
@WardF OK, this is ready to go, and important to get in before the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @edwardhartnett !
Fix missing quantize constants.
Also change the test to test with all three algorithms.
Fixes #382