Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-configurable spectrometer #6

Closed
mattias42 opened this issue Nov 15, 2017 · 4 comments
Closed

User-configurable spectrometer #6

mattias42 opened this issue Nov 15, 2017 · 4 comments
Assignees
@dlnorgaard
Labels
needs testing Probably fixed, but needs to be verified

Comments

@mattias42
Copy link
Contributor

Make it possible to configure a 'custom' spectrometer using configurations files. This to make the program able to handle future types of spectrometers without having to rebuild.
Examples of parameters to save are number of pixels and saturation intensity.
@dlnorgaard
Copy link

dlnorgaard commented Nov 16, 2017 •
edited

  • Need to be able to enter in custom model name, max intensity - default 4095, covered or dark pixels (from, to) - currently 50 to 200 pixels.
  • Update code that spits out spectrometer model in evaluation log
  • Remove the UV checkbox and replace it with the covered pixels from/to in ReEvaluation dialog.

dlnorgaard pushed a commit that referenced this issue Mar 12, 2018
Merge pull request #6 from NOVACProject/master
15ae2ab 
fix to #19
@mattias42 mattias42 mentioned this issue Feb 6, 2019
Open
@dlnorgaard dlnorgaard self-assigned this Feb 6, 2019
@mattias42
Copy link
Contributor Author

mattias42 commented Jun 13, 2019 •
edited

Implemented adding a custom spectrometer model, with custom name and dynamic range in version 3.2 through commit 0ee10c2 . Was implementing this anyway in NovacPPP and made the same solution here.

@mattias42 mattias42 reopened this Jun 13, 2019
@mattias42
Copy link
Contributor Author

Also updated the SpectrometerModel with number of pixels, in commit baf9950.

@mattias42 mattias42 added the needs testing Probably fixed, but needs to be verified label Jun 15, 2019
@dlnorgaard
Copy link

Looks like it works to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlnorgaard dlnorgaard

Labels
needs testing Probably fixed, but needs to be verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattias42 @dlnorgaard